Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ValidityLowerBoundSupportedInEra #279

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Sep 27, 2023

Changelog

- description: |
    Delete `ValidityLowerBoundSupportedInEra`.  Use `AllegraEraOnwards` instead
    Delete `validityLowerBoundSupportedInEra`.  Use `inEonForEra` or equivalent instead
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/replace-ValidityLowerBoundSupportedInEra branch from 6cafc31 to ab09ed5 Compare September 27, 2023 15:09
@newhoggy newhoggy marked this pull request as ready for review September 27, 2023 15:09
@newhoggy newhoggy force-pushed the newhoggy/replace-ValidityLowerBoundSupportedInEra branch from ab09ed5 to 0f90a5a Compare September 28, 2023 06:35
@newhoggy newhoggy force-pushed the newhoggy/replace-ValidityLowerBoundSupportedInEra branch from 0f90a5a to 06dd054 Compare September 28, 2023 07:57
@newhoggy newhoggy added this pull request to the merge queue Sep 28, 2023
Merged via the queue into main with commit 90047c2 Sep 28, 2023
20 checks passed
@newhoggy newhoggy deleted the newhoggy/replace-ValidityLowerBoundSupportedInEra branch September 28, 2023 09:07
newhoggy added a commit that referenced this pull request Mar 11, 2024
…based-command-structure

Regularise era based command structure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants