Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to tasty-discover #31

Merged
merged 1 commit into from
May 30, 2023
Merged

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented May 30, 2023

Description

The switch to tasty-discover affords us more flexibility because the discovery tool supports a wide range of test types.

tasty-discover supports hspec (previously hspec-discover was used), so there is no regression in terms of test types supported.

tasty also tells you how to re-run that specific test for each test that failed. For example:

      Use "--pattern '$NF ~ /TxMetadataNumberOutOfRange/' --hedgehog-replay '1: Seed 4728764660645527119 2003600736746438781'" to reproduce from the command-line.

      Use -p '/TxMetadataNumberOutOfRange/' to rerun this test only.

tasty-hedgehog is used to adapt property tests to tasty.

Changelog

- description: |
    Switch to `tasty-discover`
  compatibility: no-api-changes
  type: test

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy force-pushed the newhoggy/switch-to-tasty-discover branch from fb9aa43 to 7982911 Compare May 30, 2023 05:46
@newhoggy newhoggy force-pushed the newhoggy/switch-to-tasty-discover branch from 7982911 to 80ec44f Compare May 30, 2023 05:49
@newhoggy newhoggy added this pull request to the merge queue May 30, 2023
Merged via the queue into main with commit cf22f01 May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants