Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New shelleyToAlonzoEraToShelleyToBabbageEra function #329

Merged

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Oct 19, 2023

Changelog

- description: |
    New `shelleyToAlonzoEraToShelleyToBabbageEra` function
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

To complete this TODO https://github.com/input-output-hk/cardano-cli/blob/newhoggy/upgrade-to-cardano-api-8.27.0.0/cardano-cli/src/Cardano/CLI/EraBased/Run.hs#L77-L84

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@newhoggy newhoggy force-pushed the newhoggy/new-shelleyToAlonzoEraToShelleyToBabbageEra-function branch from 3708ebb to 3c1308c Compare October 19, 2023 14:24
@newhoggy newhoggy marked this pull request as ready for review October 19, 2023 14:25
@newhoggy newhoggy added this pull request to the merge queue Oct 19, 2023
Merged via the queue into main with commit 0e670df Oct 19, 2023
25 checks passed
@newhoggy newhoggy deleted the newhoggy/new-shelleyToAlonzoEraToShelleyToBabbageEra-function branch October 19, 2023 15:09
newhoggy added a commit that referenced this pull request Mar 11, 2024
…no-api-8.25.0.1

Upgrade to `cardano-api-8.25.0.1`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants