Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore the inclusion of datum hashes in Alonzo era tx bodies #398

Merged
merged 1 commit into from Dec 6, 2023

Conversation

Jimbo4350
Copy link
Contributor

Changelog

- description: |
    Restore the inclusion of datum hashes in Alonzo era tx bodies
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Thanks!

@carbolymer carbolymer self-requested a review December 6, 2023 14:55
@Jimbo4350 Jimbo4350 force-pushed the jordan/include-datum-hashes-in-alonzo-txbody branch from b36f76c to 3522eae Compare December 6, 2023 14:58
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit 28a3fb4 Dec 6, 2023
20 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/include-datum-hashes-in-alonzo-txbody branch December 6, 2023 15:51
newhoggy pushed a commit that referenced this pull request Mar 11, 2024
…ypes

Command argument types for `genesis` commands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants