-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CIP-1694 API - Part 1 #41
Conversation
( CommitteeDelegationCertificate | ||
(CommitteeColdKeyHash _ckh) | ||
(CommitteeHotKeyHash _hkh) | ||
) = error "TODO CIP-1694 Need ledger types for CommitteeDelegationCertificate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
toShelleyCertificate | ||
( CommitteeHotKeyUnregistrationCertificate | ||
(CommitteeColdKeyHash _ckh) | ||
) = error "TODO CIP-1694 Need ledger types for CommitteeHotKeyUnregistrationCertificate" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO
c724b58
to
4c5c174
Compare
e21d8be
to
d690e02
Compare
CommitteeDelegationCertificate{} -> "Constitution Committee key delegation" | ||
CommitteeHotKeyUnregistrationCertificate{} -> "Constitution Committee hot key unregistration" | ||
CommitteeDelegationCertificate{} -> "Constitution committee member key delegation" | ||
CommitteeHotKeyDeregistrationCertificate{} -> "Constitution committee member hot key deregistration" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is actually called "unregister" instead of "deregister" in the ledger. A future version of the ledger will call it "resign" instead. See https://input-output-rnd.slack.com/archives/C057E9CJTPH/p1685008671862099?thread_ts=1684866116.549819&cid=C057E9CJTPH
9695e0f
to
4f614c7
Compare
MaryEra -> no | ||
AlonzoEra -> no | ||
BabbageEra -> no | ||
ConwayEra -> yes OnChainGovernanceInConwayEra |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are adding multiple types. Instead of adding a feature per introduced era sensitive type, we could use a single feature OnChainGovernanceFeature
.
This has a number of advantages:
- We don't have to add lots of
*SupportedInEra
types as we go. Just the oneOnChainGovernanceFeature
will do. - We get a free generator for
FeatureValue OnChainGovernanceFeature a
provided we have a generator fora
. This will help us get our generators more uniform. We have not handle era-sensitive types consistently in the past. - Our types can be simpler. For instance
TxGovernanceAction
andTxVote
are regular product types, not GADTs. - We don't have to plural types like
TxGovernanceActions
orTxVotes
. Both of these were needed because it's the list that is era-sensitive. UsingFeatureValue OnChainGovernanceFeature [a]
we don't have to wrap lists anymore.
1b097b5
to
f88f82f
Compare
f88f82f
to
c053ced
Compare
* CommitteeColdKey * CommitteeDelegationCertificate * CommitteeHotKey * CommitteeHotKeyUnregistrationCertificate * GenesisKeyDelegationCertificate * makeCommitteeDelegationCertificate * makeCommitteeHotKeyUnregistrationCertificate
* `Cardano.Api.DRepMetadata` * `DRepMetadata` * `DRepMetadataReference` * `DRepMetadataValidationError` * `DRepKey` * `validateAndHashDRepMetadata`
b79b490
to
33281f2
Compare
33281f2
to
f218248
Compare
f218248
to
5ee7bfc
Compare
Fix stylish haskell in github action workflow
Description
CIP-1694
Changelog
Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.