Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New requireShelleyBasedEra function #58

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

newhoggy
Copy link
Collaborator

Description

Changelog

- description: |
    New `requireShelleyBasedEra` function
  compatibility: compatible
  type: feature

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

qSbe <- pure (getSbe $ cardanoEraStyle era)
& onLeft left
sbe <- requireShelleyBasedEra era
& onNothing (left ByronEraNotSupported)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an improvement on before because we have better control of the error that is thrown.

@newhoggy newhoggy marked this pull request as ready for review June 16, 2023 10:12
@newhoggy newhoggy enabled auto-merge June 16, 2023 10:18
@newhoggy newhoggy added this pull request to the merge queue Jun 16, 2023
Merged via the queue into main with commit d68f687 Jun 16, 2023
100 of 101 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants