Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR changelog check #75

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jun 23, 2023

Description

Add GHA checking for changelog correctness in an open pr

Changelog

- description: |
    Add changelog validation to github action
  # no-changes: the API has not changed
  # compatible: the API has changed but is non-breaking
  # breaking: the API has changed in a breaking way
  compatibility: no-api-changes
  # feature: the change implements a new feature in the API
  # bugfix: the change fixes a bug in the API
  # test: the change fixes modifies tests
  # maintenance: the change involves something other than the API
  # If more than one is applicable, it may be put into a list.
  type: maintenance

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer force-pushed the mgalazyn/feature/check-changelog-workflow branch 26 times, most recently from 74a37f9 to 68e6165 Compare June 23, 2023 19:33
@carbolymer carbolymer marked this pull request as ready for review June 23, 2023 19:35
@carbolymer carbolymer force-pushed the mgalazyn/feature/check-changelog-workflow branch from 68e6165 to 31b583f Compare June 23, 2023 19:37
@newhoggy newhoggy force-pushed the mgalazyn/feature/check-changelog-workflow branch from 31b583f to 75d6a4c Compare June 24, 2023 01:25
@newhoggy
Copy link
Collaborator

newhoggy commented Jun 24, 2023

Tested. It works well! Good effort!

@newhoggy newhoggy enabled auto-merge June 24, 2023 01:31
@newhoggy newhoggy added this pull request to the merge queue Jun 24, 2023
Merged via the queue into main with commit 873c34f Jun 24, 2023
17 of 18 checks passed
@newhoggy newhoggy deleted the mgalazyn/feature/check-changelog-workflow branch June 24, 2023 01:57
newhoggy added a commit that referenced this pull request Mar 11, 2024
Fixup changelog for `cardano-cli-8.3.1.0`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants