Parameterise Certificate with era
#84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/certificates-parameterised
branch
from
b42a401 to
b4d5354
Compare
newhoggy
requested review from
dcoutts,
Jimbo4350,
erikd,
carbolymer and
disassembler
as code owners
Jimbo4350
approved these changes
Jul 3, 2023
| @@ -558,3 +560,13 @@ withShelleyBasedEraConstraintsForLedger = \case | |||
| ShelleyBasedEraAlonzo -> id | |||
| ShelleyBasedEraBabbage -> id | |||
| ShelleyBasedEraConway -> id | |||
|
|
|||
| cardanoEraConstraints :: CardanoEra era -> (Typeable era => IsCardanoEra era => a) -> a | |||
There was a problem hiding this comment.
We need to reconcile this with: getIsCardanoEraConstraint
Jimbo4350
approved these changes
Jul 3, 2023
| => CardanoEra era | ||
| -> AsType (f era) | ||
| -> TextEnvelopeType | ||
| textEnvelopeTypeInEra _ = |
There was a problem hiding this comment.
The additional first argument (vs testEnvelopeType) is for assisting type inference.
carbolymer
approved these changes
Jul 3, 2023
newhoggy
pushed a commit
that referenced
this pull request
Mar 11, 2024
…r-messages Conway error messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parameterise
CertificatewitheraChangelog
Checklist
CHANGELOG.mdfor affected package.cabalfiles are updatedhlint. See.github/workflows/check-hlint.ymlto get thehlintversionstylish-haskell. See.github/workflows/stylish-haskell.ymlto get thestylish-haskellversionghc-8.10.7andghc-9.2.7Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.