Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename era to sbe when type is ShelleyBasedEra #98

Merged
merged 1 commit into from
Jul 11, 2023

Conversation

newhoggy
Copy link
Collaborator

@newhoggy newhoggy commented Jul 5, 2023

Changelog

- description: |
    Rename `era` to `sbe` when type is `ShelleyBasedEra`
  compatibility: no-api-changes
  type: maintenance

Context

It can be confusing when era has the type ShelleyBasedEra era because it is also used for values of the type CardanoEra era.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

Base automatically changed from newhoggy/upgrade-to-cardano-ledger-1.3 to main July 5, 2023 12:15
@newhoggy newhoggy force-pushed the newhoggy/rename-ShelleyBasedEra-variables-to-sbe branch from c955b61 to a47d35a Compare July 9, 2023 00:11
@newhoggy newhoggy marked this pull request as ready for review July 9, 2023 00:39
@newhoggy newhoggy force-pushed the newhoggy/rename-ShelleyBasedEra-variables-to-sbe branch 2 times, most recently from 1224a4b to 25eb20c Compare July 11, 2023 10:14
@newhoggy newhoggy force-pushed the newhoggy/rename-ShelleyBasedEra-variables-to-sbe branch from 25eb20c to cfd789e Compare July 11, 2023 10:21
@newhoggy newhoggy added this pull request to the merge queue Jul 11, 2023
Merged via the queue into main with commit ef0a3be Jul 11, 2023
@newhoggy newhoggy deleted the newhoggy/rename-ShelleyBasedEra-variables-to-sbe branch July 11, 2023 12:39
newhoggy added a commit that referenced this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants