Fixup time related instances #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaredCorduan
approved these changes
Mar 13, 2023
* Remove `To/FromCBOR` instances for `NominalDiffTime`, since they did rounding. Newly added functions `encodeNominalDiffTimeMicro`/`decodedNominalDiffTimeMicro` can be used to recover previous behavior. Correct instances that do not perform any rounding will be added in some future version, for now `decodeNominalDiffTime` and `encodeNominalDiffTime` can be used. * Add `decodeNominalDiffTime` and `encodeNominalDiffTime` * Add `To/FromCBOR` for all `Fixed a`, not just `Nano` and `Pico` * Bump up the version to 1.7.0.0
* Addition of `ToJSON`/`FromJSON` instances for `SystemStart` * Addition of `ToCBOR`/`FromCBOR` instances for `RelativeTime` and `SlotLength`
lehins
force-pushed
the
lehins/fixup-time-related-instances
branch
from
a185a0a to
2032bae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To/FromCBORinstance forNominalDiffTimeis pretty broken, since there is loss of precision on roundtripping. This PR fixes it by removing the instance altogether in favor of helper functions that can do the same job, but they are more explicit.Also moving orphan
To/FromJSONinstances forSystemStartfromcardano-nodeAdding a couple of other potentially useful instances