Include additional tests to BLS bindings #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iquerejeta
force-pushed
the
iquerejeta/bls-tests
branch
from
c94aad8 to
e189c31
Compare
lehins
approved these changes
Apr 10, 2023
cardano-crypto-class/src/Cardano/Crypto/EllipticCurve/BLS12_381/Internal.hs
Outdated
Show resolved
Hide resolved
cardano-crypto-class/src/Cardano/Crypto/EllipticCurve/BLS12_381/Internal.hs
Outdated
Show resolved
Hide resolved
lehins
requested changes
Apr 11, 2023
Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
iquerejeta
force-pushed
the
iquerejeta/bls-tests
branch
from
d0c5efd to
c985393
Compare
lehins
added a commit
that referenced
this pull request
May 18, 2023
* Include additional tests to BLS bindings * Final verify fails with random values * Add check that blsZero is infinity, and simplify code * Generate random integers from larger space Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
lehins
added a commit
that referenced
this pull request
May 23, 2023
* Include additional tests to BLS bindings * Final verify fails with random values * Add check that blsZero is infinity, and simplify code * Generate random integers from larger space Co-authored-by: Alexey Kuleshevich <alexey.kuleshevich@iohk.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including more unit tests to BLS bindings. This covers all tests included in the Plutus PR#5231, allowing the latter to reduce its test suite.
Similarly we expose the zero element of both Group1 and Group2.