Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes things as follows:
DSIGN:
DSIGNMAlgorithmBase
class disappears; its functionality is provided by the existingDSIGNAlgorithm
classDSIGNMAlgorithm
class remains, but becomes a subclass ofDSIGNAlgorithm
DSIGNMAlgorithmBase
that do not involve sign keys or seeds will be shared between the pure (DSIGNAlgorithm
) and mlocked (DSIGNMAlgorithm
) APIs, since we only need to mlock seeds and sign keys. TheM
flavors of those methods and types have been deleted.genKeyDSIGN(M)
,deriveVerKeyDSIGN(M)
, etc.). All DSIGN algorithms must support a pure API (DSIGNAlgorithm
); those that also support mlocked DSIGN (currently only ED25519) additionally supportDSIGNMAlgorithm
.KES:
KESSignAlgorithm
has been merged intoKESAlgorithm
, which now offers the full range of KES operations. Since the mlocking monad (m
) is no longer a typeclass parameter, the split is no longer necessary, and conceptually, it does not make sense to have a KES algorithm that can only verify, but not sign.