Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement conway governance committee hot-key-gen command #136

Merged
merged 1 commit into from
Aug 5, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Aug 3, 2023

Changelog

- description: |
    Implement conway governance committee hot-key-gen command
  compatibility: compatible
  type: feature

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy force-pushed the newhoggy/committee-hot-key-gen branch from 9a2811e to cdcbdd8 Compare August 3, 2023 15:09
@newhoggy newhoggy changed the title Newhoggy/committee hot key gen Implement conway governance committee hot-key-gen command Aug 3, 2023
@newhoggy newhoggy marked this pull request as ready for review August 3, 2023 15:10
@newhoggy newhoggy force-pushed the newhoggy/committee-hot-key-gen branch 2 times, most recently from 8a1a105 to 693f0c3 Compare August 5, 2023 08:03
@newhoggy newhoggy force-pushed the newhoggy/committee-hot-key-gen branch from 693f0c3 to 0233852 Compare August 5, 2023 08:03
@newhoggy newhoggy added this pull request to the merge queue Aug 5, 2023
Merged via the queue into main with commit ffb1374 Aug 5, 2023
@newhoggy newhoggy deleted the newhoggy/committee-hot-key-gen branch August 5, 2023 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants