Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wire up remaining DReps #137

Merged
merged 2 commits into from
Aug 3, 2023
Merged

Wire up remaining DReps #137

merged 2 commits into from
Aug 3, 2023

Conversation

Jimbo4350
Copy link
Contributor

Changelog

- description: |
    Add always abstain, always no confidence and drep script hash options. NB: The drep script hash option is hidden until ledger exposed the necessary constructor.
  # no-changes: the API has not changed
  # compatible: the API has changed but is non-breaking
  # breaking: the API has changed in a breaking way
  compatibility: compatible
  # feature: the change implements a new feature in the API
  # bugfix: the change fixes a bug in the API
  # test: the change fixes modifies tests
  # maintenance: the change involves something other than the API
  # If more than one is applicable, it may be put into a list.
  type: feature

Context

Addititional context for the PR goes here.

If the PR fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

drep delegation. NB: The script hash option is hidden because ledger has
not exposed all necessary constructors.
@Jimbo4350 Jimbo4350 force-pushed the jordan/wire-up-remaining-dreps branch from 4537173 to 7160a22 Compare August 3, 2023 14:20
@Jimbo4350 Jimbo4350 force-pushed the jordan/wire-up-remaining-dreps branch from 7160a22 to 8dc7331 Compare August 3, 2023 14:41
@Jimbo4350 Jimbo4350 force-pushed the jordan/wire-up-remaining-dreps branch from 8dc7331 to 97cc411 Compare August 3, 2023 15:22
@Jimbo4350 Jimbo4350 force-pushed the jordan/wire-up-remaining-dreps branch from 97cc411 to 38c8e79 Compare August 3, 2023 15:42
@Jimbo4350 Jimbo4350 enabled auto-merge August 3, 2023 15:42
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Aug 3, 2023
Merged via the queue into main with commit 68931f2 Aug 3, 2023
@Jimbo4350 Jimbo4350 deleted the jordan/wire-up-remaining-dreps branch August 3, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants