Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement conway governance committee key-hash command #144

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Aug 5, 2023

Changelog

- description: |
    Implement `conway governance committee key-hash` command
# uncomment types applicable to the change:
  type:
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - documentation  # change in code docs, haddocks...

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy force-pushed the newhoggy/implement-conway_governance_committee_key-hash-command branch from d68905e to dd831b3 Compare August 5, 2023 10:52
@newhoggy newhoggy marked this pull request as ready for review August 5, 2023 12:06
@newhoggy newhoggy requested a review from Jimbo4350 August 5, 2023 12:07
@Jimbo4350
Copy link
Contributor

This is a command that my be worth having at the top level under a command like "key". Otherwise we might find ourselves re-implementing this command under other command groups.

@newhoggy newhoggy force-pushed the newhoggy/implement-conway_governance_committee_key-hash-command branch from dd831b3 to baf5532 Compare August 7, 2023 13:11
@newhoggy newhoggy added this pull request to the merge queue Aug 7, 2023
Merged via the queue into main with commit b2dd644 Aug 7, 2023
19 checks passed
@newhoggy newhoggy deleted the newhoggy/implement-conway_governance_committee_key-hash-command branch August 7, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants