Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all uses of toS, purer, cborError and intercalate from Cardano.Prelude #182

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Aug 17, 2023

Changelog

- description: |
    Remove all uses of `toS`, `purer`, `cborError` and `intercalate` from `Cardano.Prelude`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

So that we don't accidentally duplicate deprecated code.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy changed the title Remove all uses of toS Remove all uses of toS, purer, cborError and intercalate from Cardano.Prelude Aug 17, 2023
@newhoggy newhoggy marked this pull request as ready for review August 17, 2023 14:39
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think cardano-prelude dependency in cabal file can be removed now, right?

@newhoggy newhoggy force-pushed the newhoggy/remove-all-uses-of-toS branch 2 times, most recently from 0b7d738 to e7c47f0 Compare August 17, 2023 14:51
@newhoggy newhoggy force-pushed the newhoggy/remove-all-uses-of-toS branch from e7c47f0 to b1b09be Compare August 17, 2023 14:54
@newhoggy newhoggy requested a review from carbolymer August 17, 2023 15:09
@newhoggy newhoggy force-pushed the newhoggy/remove-all-uses-of-toS branch 2 times, most recently from 842c072 to 2ccdad2 Compare August 18, 2023 02:06
@newhoggy newhoggy force-pushed the newhoggy/remove-all-uses-of-toS branch from 2ccdad2 to e89031e Compare August 18, 2023 03:54
@newhoggy newhoggy added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit 724d73d Aug 18, 2023
@newhoggy newhoggy deleted the newhoggy/remove-all-uses-of-toS branch August 18, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants