Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some error types #186

Merged
merged 3 commits into from
Aug 18, 2023
Merged

Move some error types #186

merged 3 commits into from
Aug 18, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Aug 18, 2023

Changelog

- description: |
    Changes:
    * Move to own modules under `Cardano.CLI.Types.Errors.GovernanceCmdError`:
      * `GovernanceCmdError`
      * `ShelleyStakeAddressCmdError`
      * `StakeAddressDelegationError`
      * `StakeAddressRegistrationError`
      * `ScriptDecodeError`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Putting the error types under neutral territory Cardano.CLI.Types.Errors supports the notion that these types are neither legacy nor era-based.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy requested review from carbolymer and Jimbo4350 and removed request for carbolymer August 18, 2023 10:54
@newhoggy newhoggy force-pushed the newhoggy/move-some-error-types branch from 67db4a5 to ce34cec Compare August 18, 2023 11:09
@newhoggy newhoggy marked this pull request as ready for review August 18, 2023 11:29
@newhoggy newhoggy requested a review from carbolymer August 18, 2023 11:29
@newhoggy newhoggy force-pushed the newhoggy/move-some-error-types branch from 40d5b6d to 01ecbd3 Compare August 18, 2023 11:31
@newhoggy newhoggy added this pull request to the merge queue Aug 18, 2023
Merged via the queue into main with commit 4a19503 Aug 18, 2023
@newhoggy newhoggy deleted the newhoggy/move-some-error-types branch August 18, 2023 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants