Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable --drep-script-hash option #204

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Enable `--drep-script-hash` option
# uncomment types applicable to the change:
  type:
   - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
   - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here.

If the PR fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/feature/enable-drep-hash branch from e2ec24f to f49de5c Compare August 24, 2023 14:48
@carbolymer carbolymer marked this pull request as ready for review August 24, 2023 14:49
@carbolymer carbolymer force-pushed the mgalazyn/feature/enable-drep-hash branch from f49de5c to 59a3caa Compare August 24, 2023 15:04
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carbolymer carbolymer force-pushed the mgalazyn/feature/enable-drep-hash branch from 59a3caa to d4d3d73 Compare August 24, 2023 15:12
@carbolymer carbolymer added this pull request to the merge queue Aug 24, 2023
Merged via the queue into main with commit 31125d0 Aug 24, 2023
19 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/enable-drep-hash branch August 24, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants