Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to cardano-api-8.17.0.0 #210

Merged
merged 1 commit into from
Aug 28, 2023

Conversation

newhoggy
Copy link
Contributor

Changelog

- description: |
    Upgrade to `cardano-api-8.17.0.0`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review August 28, 2023 11:00
@newhoggy newhoggy force-pushed the newhoggy/upgrade-to-cardano-api-8.17.0.0 branch from d3935e3 to 9aa51eb Compare August 28, 2023 11:02
@newhoggy newhoggy requested review from a team as code owners August 28, 2023 11:02
@@ -215,7 +215,7 @@ txSpendUTxOByronPBFT nId sk txIns outs = do
TxMintNone
TxScriptValidityNone
TxGovernanceActionsNone
TxVotesNone
Nothing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only downside. We should use the type's records to make this more obvious.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep. Will do this in a future PR.

@newhoggy newhoggy force-pushed the newhoggy/upgrade-to-cardano-api-8.17.0.0 branch from 9aa51eb to ae662f0 Compare August 28, 2023 21:23
@newhoggy newhoggy force-pushed the newhoggy/upgrade-to-cardano-api-8.17.0.0 branch from ae662f0 to e87013e Compare August 28, 2023 21:34
@newhoggy newhoggy requested a review from a team as a code owner August 28, 2023 21:34
@newhoggy newhoggy enabled auto-merge August 28, 2023 22:17
@newhoggy newhoggy added this pull request to the merge queue Aug 28, 2023
Merged via the queue into main with commit 15174c9 Aug 28, 2023
@newhoggy newhoggy deleted the newhoggy/upgrade-to-cardano-api-8.17.0.0 branch August 28, 2023 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants