Move transaction command code into era based #229
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
The purpose of this change is to move the transaction command run functions into the era-based command structure so that work can start on making it era-sensitive.
There have been numerous attempts to do this before, but they all failed because of rebase conflicts.
This PR does the minimum thing which is to move the functions without change into
Cardano.CLI.EraBased.Run.Transaction
in a way thatgit
can recognise it as a move.After this the
Cardano.CLI.Legacy.Run.Transaction
module is recreated to delegate there and the legacy prefix removed from functions inCardano.CLI.EraBased.Run.Transaction
.Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7