-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Era sensitive transaction run commands #230
Era sensitive transaction run commands #230
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This doesn't break the existing tx build commands right?
= EraBasedGovernanceCmds (EraBasedGovernanceCmds era) | ||
| TransactionCmds (TransactionCmds era) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to name this EraBasedTransactionCmds
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't break existing commands.
My thoughts are we don't need to have the EraBased
prefix because we already qualify the legacy stuff with Legacy
and when we get to the point where we can delete the legacy stuff EraBased
is the only state of things and no prefix is necessary to distinguish it from anything else.
I plan to remove EraBased
from prefix from the governance commands.
Changelog
Context
Era-based versions of transaction commands
Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7