Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Era sensitive transaction run commands #230

Merged
merged 5 commits into from
Sep 4, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Sep 1, 2023

Changelog

- description: |
    Era sensitive transaction run commands
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Era-based versions of transaction commands

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review September 1, 2023 20:12
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This doesn't break the existing tx build commands right?

= EraBasedGovernanceCmds (EraBasedGovernanceCmds era)
| TransactionCmds (TransactionCmds era)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to name this EraBasedTransactionCmds?

Copy link
Contributor Author

@newhoggy newhoggy Sep 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't break existing commands.

My thoughts are we don't need to have the EraBased prefix because we already qualify the legacy stuff with Legacy and when we get to the point where we can delete the legacy stuff EraBased is the only state of things and no prefix is necessary to distinguish it from anything else.

I plan to remove EraBased from prefix from the governance commands.

@newhoggy newhoggy added this pull request to the merge queue Sep 4, 2023
@newhoggy newhoggy removed this pull request from the merge queue due to a manual request Sep 4, 2023
@newhoggy newhoggy added this pull request to the merge queue Sep 4, 2023
Merged via the queue into main with commit 062fa54 Sep 4, 2023
21 checks passed
@newhoggy newhoggy deleted the newhoggy/era-sensitive-transaction-run-commands branch September 4, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants