Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Era-based stake-address command group #241

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Sep 4, 2023

Changelog

- description: |
    Era-based `stake-address` command group
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@newhoggy newhoggy marked this pull request as ready for review September 4, 2023 12:56
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moving on the right direction, I just think that for conway it needs to be:

cardano-cli conway stake-address stake-delegation-certificate
cardano-cli conway stake-address vote-delegation-certificate
cardano-cli conway stake-address combined-delegation-certificate

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, I'll fix that up in the next PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about stake-vote-delegation-certificate

@newhoggy newhoggy force-pushed the newhoggy/era-based-stake-address-command-group branch from 5e32208 to 8b33fa8 Compare September 4, 2023 14:20
@newhoggy newhoggy added this pull request to the merge queue Sep 4, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 4, 2023
@newhoggy newhoggy force-pushed the newhoggy/era-based-stake-address-command-group branch from 8b33fa8 to 56c5c24 Compare September 5, 2023 00:53
@newhoggy newhoggy added this pull request to the merge queue Sep 5, 2023
Merged via the queue into main with commit c8686fa Sep 5, 2023
19 checks passed
@newhoggy newhoggy deleted the newhoggy/era-based-stake-address-command-group branch September 5, 2023 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants