Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update error message for eras mismatch between node and cli #249

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Update error message for eras mismatch between node and cli
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

n/a

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@@ -558,15 +561,12 @@ runTxBuild
Refl <- testEquality era nodeEra
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both eraCasts removed from here are redundant because of this check.

@carbolymer carbolymer force-pushed the mgalazyn/fix/update-mismatched-era-error-message branch from f0bb2c1 to 3dd8dd3 Compare September 6, 2023 12:29
@carbolymer carbolymer added this pull request to the merge queue Sep 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 6, 2023
@carbolymer carbolymer removed this pull request from the merge queue due to a manual request Sep 6, 2023
@carbolymer carbolymer force-pushed the mgalazyn/fix/update-mismatched-era-error-message branch from 3dd8dd3 to 447c59c Compare September 6, 2023 15:15
@carbolymer carbolymer requested a review from Jimbo4350 September 6, 2023 15:15
@carbolymer carbolymer enabled auto-merge September 6, 2023 15:15
@carbolymer carbolymer dismissed Jimbo4350’s stale review September 6, 2023 15:16

Removed ViewPatterns

@carbolymer carbolymer added this pull request to the merge queue Sep 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 6, 2023
@carbolymer carbolymer enabled auto-merge September 7, 2023 10:41
@carbolymer carbolymer added this pull request to the merge queue Sep 7, 2023
Merged via the queue into main with commit 738c636 Sep 7, 2023
@carbolymer carbolymer deleted the mgalazyn/fix/update-mismatched-era-error-message branch September 7, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants