Simplify stake-address stake-delegation-certificate
command across eras
#256
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Originally the command constructed a
Delegatee
and aRequirements
.Both of these were unnecessary because we can construct the certificate directly from the stake pool key hash and the stake credentials.
This more direct method has the advantage of not having to handle unsupported delegatees so there are fewer error cases to handle.
The simplification allows an error constructor to be deleted.
The
caseShelleyToBabbageAndConwayEraOnwards
function is temporarily defined here pending introduction intocardano-api
. After moving that the new code is clearly much shorter.Checklist
See Running tests for more details
.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7