Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 8.9.0.0 #287

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Release 8.9.0.0 #287

merged 1 commit into from
Sep 18, 2023

Conversation

carbolymer
Copy link
Contributor

Changelog

- description: |
    Release 8.9.0.0
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
   - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here.

If the PR fixes a particular issue please provide a
link
to the issue.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@carbolymer carbolymer marked this pull request as ready for review September 18, 2023 16:40
auto-merge was automatically disabled September 18, 2023 17:18

Merge queue setting changed

@carbolymer carbolymer merged commit 7926405 into main Sep 18, 2023
20 checks passed
@carbolymer carbolymer deleted the mgalazyn/release/8.9.0.0 branch September 18, 2023 17:18
@gitmachtl
Copy link
Contributor

@carbolymer question about the commands shifting to eras:

now that commands are again shifting into era based commands, whats the best way to call the commands we had up until conway in the past to be future proof? currently all my scripts are not using any era based parameter other than in the build-raw command. i have seen that when you use byron as the era, not all functions are available, which makes sense. so, the command are enabled we further go down all the eras right? so would it be safe to use "latest" as the default era? because that would support all available command with that cli version right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants