Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to cardano-api-8.24 #324

Merged
merged 1 commit into from
Oct 3, 2023
Merged

Update to cardano-api-8.24 #324

merged 1 commit into from
Oct 3, 2023

Conversation

amesgen
Copy link
Member

@amesgen amesgen commented Oct 2, 2023

Changelog

- description: |
    Update to cardano-api-8.24
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@smelc
Copy link
Contributor

smelc commented Oct 2, 2023

This PR adds a TODO for #198 (comment) (could be addressed in this PR or in a separate one)

@amesgen> you can leave the TODO. I will take care of it shortly after this is merged 👍

@newhoggy
Copy link
Contributor

newhoggy commented Oct 3, 2023

I commented out code that depends on a later version of cardano-api so this PR can merge.

@newhoggy newhoggy added this pull request to the merge queue Oct 3, 2023
Merged via the queue into main with commit ddfc37b Oct 3, 2023
19 checks passed
@newhoggy newhoggy deleted the amesgen/releng-8.5 branch October 3, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants