Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drep certification registration: add parameters for anchor #330

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Oct 4, 2023

Changelog

- description: |
    Add `--drep-metadata-url` and `--drep-metadata-hash` to the drep registration certificate command
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Closes #198

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • NA The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

@smelc smelc changed the title Smelc/drep reg certificate add metadata Drep certification registration: add parameters for anchor Oct 4, 2023
@smelc smelc force-pushed the smelc/drep-reg-certificate-add-metadata branch 4 times, most recently from f4ccaed to 096934d Compare October 4, 2023 14:18
@smelc smelc marked this pull request as ready for review October 4, 2023 14:49
Copy link
Contributor

@CarlosLopezDeLara CarlosLopezDeLara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! thank you

➜  testdreps cardano-cli conway governance drep registration-certificate \
--drep-verification-key-file drep.vkey \
--key-reg-deposit-amt 0 \
--drep-metadata-url drep.url \
--drep-metadata-hash 52e69500a92d80f2126c836a4903dc582006709f004cf7a28ed648f732dff8d2 \
--out-file drep-reg.cert
➜  testdreps cat drep-reg.cert
{
    "type": "CertificateShelley",
    "description": "DRep Key Registration Certificate",
    "cborHex": "84108200581c95591451fb3899fcc8db3450741d9de6123a78e03ef39bf4a65ed5cf008268647265702e75726c582052e69500a92d80f2126c836a4903dc582006709f004cf7a28ed648f732dff8d2"
}

[16, [0, h'95591451FB3899FCC8DB3450741D9DE6123A78E03EF39BF4A65ED5CF'], 0, ["drep.url", h'52E69500A92D80F2126C836A4903DC582006709F004CF7A28ED648F732DFF8D2']]

@smelc
Copy link
Contributor Author

smelc commented Oct 5, 2023

cc @Jimbo4350 and @newhoggy if you want to have a look before merging. Short simple PR with green CI.

@smelc smelc force-pushed the smelc/drep-reg-certificate-add-metadata branch from 21ef1c1 to 343c4d9 Compare October 5, 2023 08:21
@Jimbo4350
Copy link
Contributor

Needs to be rebased. Having a look now.

Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! One simplifying suggestion

cardano-cli/src/Cardano/CLI/Types/Common.hs Show resolved Hide resolved
@smelc smelc force-pushed the smelc/drep-reg-certificate-add-metadata branch from 1466330 to a429d39 Compare October 6, 2023 07:43
@smelc smelc added this pull request to the merge queue Oct 6, 2023
Merged via the queue into main with commit 3cf1808 Oct 6, 2023
19 checks passed
@smelc smelc deleted the smelc/drep-reg-certificate-add-metadata branch October 6, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drep registration certificate mixed with spo registration (clean-up)
3 participants