Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conway governance vote create: make it possible to use cc hot keys #337

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Oct 5, 2023

Changelog

- description: |
    Make it possible to use cc hot keys for `conway governance vote create`
# uncomment types applicable to the change:
  type:
  - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fix #333

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • NA The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@smelc smelc mentioned this pull request Oct 5, 2023
@smelc smelc force-pushed the smelc/vote-with-cc-key branch 4 times, most recently from a264498 to 0d4958a Compare October 5, 2023 15:34
@smelc smelc marked this pull request as ready for review October 5, 2023 15:57
@CarlosLopezDeLara
Copy link
Contributor

Looking good!

➜  testcckeys cardano-cli conway governance vote create --yes --governance-action-tx-id d21d997b5dbdd90180b642c3f4f2653cea629f6134cd9dc820d0fe6f11b54af4 --governance-action-index 0 --cc-hot-verification-key-file cc-hot.vkey --out-file testyes.vote
➜  testcckeys cardano-cli conway governance vote create --no --governance-action-tx-id d21d997b5dbdd90180b642c3f4f2653cea629f6134cd9dc820d0fe6f11b54af4 --governance-action-index 0 --cc-hot-verification-key-file cc-hot.vkey --out-file testno.vote
➜  testcckeys cardano-cli conway governance vote create --abstain --governance-action-tx-id d21d997b5dbdd90180b642c3f4f2653cea629f6134cd9dc820d0fe6f11b54af4 --governance-action-index 0 --cc-hot-verification-key-file cc-hot.vkey --out-file testabstain.vote
➜  testcckeys cat testyes.vote
{
    "type": "Governance voting procedures",
    "description": "",
    "cborHex": "a18200581c16b570313c32a72dca09fcce5b7104fa491ec5c7b404148cb58aab6fa1825820d21d997b5dbdd90180b642c3f4f2653cea629f6134cd9dc820d0fe6f11b54af4008201f6"
}
➜  testcckeys cat testno.vote
{
    "type": "Governance voting procedures",
    "description": "",
    "cborHex": "a18200581c16b570313c32a72dca09fcce5b7104fa491ec5c7b404148cb58aab6fa1825820d21d997b5dbdd90180b642c3f4f2653cea629f6134cd9dc820d0fe6f11b54af4008200f6"
}
➜  testcckeys cat testabstain.vote
{
    "type": "Governance voting procedures",
    "description": "",
    "cborHex": "a18200581c16b570313c32a72dca09fcce5b7104fa491ec5c7b404148cb58aab6fa1825820d21d997b5dbdd90180b642c3f4f2653cea629f6134cd9dc820d0fe6f11b54af4008202f6"
}

@Jimbo4350 Jimbo4350 added this pull request to the merge queue Oct 5, 2023
@Jimbo4350 Jimbo4350 removed this pull request from the merge queue due to a manual request Oct 5, 2023
@Jimbo4350 Jimbo4350 merged commit 474d1eb into main Oct 5, 2023
20 checks passed
@Jimbo4350 Jimbo4350 deleted the smelc/vote-with-cc-key branch October 5, 2023 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vote with cc hot key
3 participants