Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test of voting using a cc hot key #363

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Oct 11, 2023

Changelog

- description: |
    Add test of voting using a cc hot key
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #339

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • NA The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@smelc
Copy link
Contributor Author

smelc commented Oct 11, 2023

@CarlosLopezDeLara> is it correct to test vote create --yes --cc-hot-verification-key in a pristine state where there is no existing governance action, the network is not setuped, etc.? I suppose it could be correct, it's just that the vote being created would fail when submitting the transaction containing it right?

@smelc smelc marked this pull request as ready for review October 11, 2023 09:53
@smelc smelc force-pushed the smelc/cc-hot-key-vote-add-test branch from 7275c31 to a25eb84 Compare October 12, 2023 07:39
@CarlosLopezDeLara
Copy link
Contributor

Yes, you should be able to create the vote even if the action does not exist. In such case it will be rejected by ledger when submitted.

@smelc smelc added this pull request to the merge queue Oct 16, 2023
Merged via the queue into main with commit 385af4f Oct 16, 2023
@smelc smelc deleted the smelc/cc-hot-key-vote-add-test branch October 16, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add golden test for conway governance create with cc hot keys
3 participants