Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove eras' constitution-hash #370

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Oct 12, 2023

Changelog

- description: |
    Remove the `constitution-hash` command from eras. Users can use the `constitution` query instead.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #354

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • NA New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • round trip tests
    • integration tests
      See Running tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

@smelc
Copy link
Contributor Author

smelc commented Oct 12, 2023

cc @CarlosLopezDeLara> this should fix #354

@smelc smelc force-pushed the smelc/remove-era-constitution-hash branch 3 times, most recently from be520a0 to ac31c08 Compare October 13, 2023 08:36
@smelc smelc marked this pull request as ready for review October 13, 2023 08:36
@smelc smelc force-pushed the smelc/remove-era-constitution-hash branch from ac31c08 to 3127e48 Compare October 13, 2023 13:41
@smelc smelc enabled auto-merge October 13, 2023 13:42
@smelc smelc added this pull request to the merge queue Oct 13, 2023
Merged via the queue into main with commit a6034e5 Oct 13, 2023
@smelc smelc deleted the smelc/remove-era-constitution-hash branch October 13, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cardano-cli <era> query is showing constitution-hash for all eras
3 participants