Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PR changelog check. Add core-tech group to GHA description codeowners. #46

Merged
merged 2 commits into from
Jun 26, 2023

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jun 26, 2023

Description

Add PR changelog check. Add core-tech group to GHA description codeowners and fix incorrect group names.

Changelog

- description: |
    Add PR changelog check. Add core-tech group to GHA description codeowners.
  # no-changes: the API has not changed
  # compatible: the API has changed but is non-breaking
  # breaking: the API has changed in a breaking way
  compatibility: no-api-changes
  # feature: the change implements a new feature in the API
  # bugfix: the change fixes a bug in the API
  # test: the change fixes modifies tests
  # maintenance: the change involves something other than the API
  # If more than one is applicable, it may be put into a list.
  type: maintenance

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer requested a review from a team as a code owner June 26, 2023 10:58
@carbolymer carbolymer force-pushed the mgalazyn/feature/check-changelog-workflow branch from 9159fe3 to 89c6192 Compare June 26, 2023 11:00
@carbolymer carbolymer added this pull request to the merge queue Jun 26, 2023
@carbolymer carbolymer removed this pull request from the merge queue due to a manual request Jun 26, 2023
@carbolymer carbolymer added this pull request to the merge queue Jun 26, 2023
Merged via the queue into main with commit 9a63ef7 Jun 26, 2023
17 checks passed
@carbolymer carbolymer deleted the mgalazyn/feature/check-changelog-workflow branch June 26, 2023 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants