Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

governance action: prefix stake-verification-key/stake-key arguments with --deposit-return #470

Merged

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Nov 22, 2023

Changelog

- description: |
    governance actions: prefix `--stake-verification-key-*` and `--stake-key` arguments so that they are prefixed with `--deposit-return` now.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Fixes #422

How to trust this PR

  • Only parsers within Options/Governance/Actions.hs are modified: we're not changing the behavior outside the governance action scope.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc smelc changed the title Smelc/prefix stake verification key flags with deposit return governance action: prefix stake-verification-key flags with --deposit-return Nov 22, 2023
@smelc smelc changed the title governance action: prefix stake-verification-key flags with --deposit-return governance action: prefix stake-verification-key/stake-key flags with --deposit-return Nov 22, 2023
@smelc smelc changed the title governance action: prefix stake-verification-key/stake-key flags with --deposit-return governance action: prefix stake-verification-key/stake-key arguments with --deposit-return Nov 22, 2023
@smelc smelc force-pushed the smelc/prefix-stake-verification-key-flags-with-deposit-return branch from f1c9cac to 29f1c6a Compare November 22, 2023 12:54
@smelc smelc marked this pull request as ready for review November 22, 2023 13:01
@smelc smelc added this pull request to the merge queue Nov 22, 2023
Merged via the queue into main with commit 49b74c9 Nov 22, 2023
21 checks passed
@smelc smelc deleted the smelc/prefix-stake-verification-key-flags-with-deposit-return branch November 22, 2023 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace --stake-verification-key-file with --deposit-return-stake-verification-key-file on all action commands
3 participants