Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Byron Tx #478

Merged
merged 8 commits into from
Dec 6, 2023
Merged

Remove Byron Tx #478

merged 8 commits into from
Dec 6, 2023

Conversation

Jimbo4350
Copy link
Contributor

@Jimbo4350 Jimbo4350 commented Nov 23, 2023

Changelog

- description: |
    Remove ByronTx
    Bump to cardano-api-8.36.0.1
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@Jimbo4350 Jimbo4350 force-pushed the jordan/remove-byron-tx branch 7 times, most recently from 4ad6660 to 52d28d0 Compare December 4, 2023 20:18
@Jimbo4350 Jimbo4350 changed the title WIP: Remove Byron Tx Remove Byron Tx Dec 4, 2023
@Jimbo4350 Jimbo4350 marked this pull request as ready for review December 4, 2023 20:19
@newhoggy newhoggy force-pushed the jordan/remove-byron-tx branch from 6f31c68 to 86ddb27 Compare December 6, 2023 10:37
@Jimbo4350 Jimbo4350 added this pull request to the merge queue Dec 6, 2023
Merged via the queue into main with commit 7440aac Dec 6, 2023
19 checks passed
@Jimbo4350 Jimbo4350 deleted the jordan/remove-byron-tx branch December 6, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants