Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete help texts for create-protocol-parameters-update #484

Merged
merged 1 commit into from Nov 27, 2023

Conversation

carlhammann
Copy link
Contributor

@carlhammann carlhammann commented Nov 27, 2023

Changelog

- description: |
    Add missing help texts for `create-protocol-parameters-update`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  - documentation  # change in code docs, haddocks...

Context

This closes #482.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

Copy link
Contributor

@CarlosLopezDeLara CarlosLopezDeLara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@CarlosLopezDeLara CarlosLopezDeLara added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit d4c1a35 Nov 27, 2023
21 checks passed
@CarlosLopezDeLara CarlosLopezDeLara deleted the ch/protocol-parameters-update-help-texts branch November 27, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete the help for create-protocol-parameters-update
2 participants