Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify previous governance action parameters across actions #511

Merged
merged 1 commit into from Dec 7, 2023

Conversation

mkoura
Copy link
Contributor

@mkoura mkoura commented Dec 6, 2023

Changelog

- description: |
    Use the same parameter names for previous governance action txid and tx index in all governance actions.
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

The create-no-confidence is using --governance-action-tx-id and --governance-action-index while all the other actions use --prev-governance-action-tx-id and --prev-governance-action-index.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@smelc
Copy link
Contributor

smelc commented Dec 7, 2023

For you @CarlosLopezDeLara

@mkoura mkoura changed the title Unify previous governance action argument across actions Unify previous governance action parameters across actions Dec 7, 2023
Copy link
Contributor

@Jimbo4350 Jimbo4350 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mkoura mkoura added this pull request to the merge queue Dec 7, 2023
Merged via the queue into main with commit b0cf3f0 Dec 7, 2023
24 checks passed
@mkoura mkoura deleted the mkoura/prev-governance-action-consistency-fix branch December 7, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants