Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove merge_group trigger from changelog check CI #53

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jun 29, 2023

Changelog

- description: |
    Remove merge_group trigger from changelog check CI
  compatibility: no-api-changes
  type: maintenance

Context

merge_group does not make sense for the changelog check because that check only ensures the changelog section in the PR is well formed and doesn't relate to any committed code.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy requested review from a team as code owners June 29, 2023 09:51
@newhoggy newhoggy added this pull request to the merge queue Jun 29, 2023
Merged via the queue into main with commit 79a4dea Jun 29, 2023
@newhoggy newhoggy deleted the newhoggy/remove-merge_group-from-changelog-check-ci branch June 29, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants