Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to optparse-applicative-fork-0.18.1.0 #74

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

newhoggy
Copy link
Contributor

@newhoggy newhoggy commented Jul 12, 2023

Changelog

- description: |
    Upgrade to `optparse-applicative-fork-0.18.1.0`
  compatibility: compatible
  type: maintenance

Context

Upgrade to optparse-applicative-fork-0.18.1.0 to unblock ghc-9.6 work. This will affect the formatting of how the CLI usage is rendered so there will be a lot of formatting changes in the golden files.

optparse-applicative-fork-0.18.1.0 is already published to CHaP, however, there is currently an SRP which will be removed once the CHaP index includes the optparse-applicative-fork-0.18.1.0 package version.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • The change log section in the PR description has been filled in
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • The changelog section in the PR is updated to describe the change
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@newhoggy newhoggy marked this pull request as ready for review July 12, 2023 14:51
Copy link
Contributor

@carbolymer carbolymer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to maintain the fork in the first place?

@newhoggy newhoggy force-pushed the newhoggy/upgrade-to-optparse-applicative-fork-0.18.1.0 branch from d4c2ce9 to 699716e Compare July 12, 2023 22:46
@newhoggy newhoggy requested review from a team as code owners July 12, 2023 22:46
cabal.project Outdated
source-repository-package
type: git
location: https://github.com/input-output-hk/optparse-applicative
tag: a85e8bcef4c3411aa3353e472b84e1ce46a83d7d
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in CHaP now right?

@erikd erikd force-pushed the newhoggy/upgrade-to-optparse-applicative-fork-0.18.1.0 branch from 699716e to 6e7986c Compare July 13, 2023 03:20
@erikd erikd added this pull request to the merge queue Jul 13, 2023
Merged via the queue into main with commit db0127b Jul 13, 2023
@erikd erikd deleted the newhoggy/upgrade-to-optparse-applicative-fork-0.18.1.0 branch July 13, 2023 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants