Reduce use of foreign key constraints and depend more heavily on BlockNo #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikd
force-pushed
the
erikd/no-foreign-keys-does-this-work-3
branch
from
b81c61f to
42e98a5
Compare
While testing it was found that if all foreign key constraints were removed from the generated schema migrations, total chain sync time on mainnet dropped from 6 days to a little over 3 days. These constraints do very little to improve data integrity of the data in the database because they are already checked in Haskell land. They can therefore be dropped. The Haskell land code will however need to be modified/updated to work around the lack of these constraints. For example removing these foreign key constraints means that `OnDeleteCascade` will no longer work and will therefore have to be done manually. This is a small price to pay for the sync speed improvements.
erikd
force-pushed
the
erikd/no-foreign-keys-does-this-work-3
branch
from
42e98a5 to
beabf9a
Compare
Needed to drop the reliance of foreign key constraints because their use forced PostgreSQL to validate the foreign keys before the data was inserted. Therefore using `BlockNo` should result in faster data insertion into the database. This also required massive changes across most of the code base. Closes: #1082
Rollbacks are now done on the `block_no` field, so adding indicies for this field in all tables should help improve rollback speed.
These got reintroduced by mistake when rebasing against master. They have all be replaced with explicit delete statements.
erikd
force-pushed
the
erikd/no-foreign-keys-does-this-work-3
branch
from
beabf9a to
58147d5
Compare
erikd
changed the title
|
I have been running this for nearly two weeks, on top of snapshotting and restoring the database. Seems fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.