Improve fetching of pool offline metadata #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we now check that the content-type is some form of JSON and we return a `PoolOfflineData` struct, we also rename the function to `httpGetPoolOfflineData`. Closes: #1270
Can be run in two ways: ``` cabal run -- http-get-json-metadata <url> cabal run -- http-get-json-metadata <url> <hash> ``` The first of the above two commands does not check the correctness of the metadata hash (eg as specified in the `PoolMetadataRef` table). The second of the above two commands does check the hash. If the user does not know the hash, they can provide a dummy hash like "00". The hash check will then fail, providing the actual hash. If this actual hash is then supplied again it should pass. On success the program will print "Success" and the JSON. On failure it prints the error.
Just a debug/test program that pulls PoolMetadataRef info from the database and retries them.
erikd
force-pushed
the
erikd/http-offline-data
branch
from
b667bf8 to
38a8aaa
Compare
reqlez
pushed a commit
to cardano-bsd-alliance/cardano-db-sync
that referenced
this pull request
Oct 7, 2022
…offline-data Improve fetching of pool offline metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.