Fix rollbacks for epoch table #1370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously there were no rollbacks on the epoch table because it was assumed that the roll forward would fix it. That was unfortunately not the case. Closes: #1363
kderme
approved these changes
Mar 1, 2023
| convert mr = | ||
| case mr of | ||
| Nothing -> Nothing | ||
| Just (_, Value Nothing) -> Nothing -- Should not ever happen. |
There was a problem hiding this comment.
Personal note this can't happen because it's only null for genesis which doesn't have a blockNo in the first place.
|
I intend to check the that this fixes if when the epoch rolls over in about an hour. |
|
Seemed to work over the most recent epoch transition. Will merge this and keep an eye on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.