Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve concurrency and exceptions handling #1447

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Conversation

kderme
Copy link
Contributor

@kderme kderme commented Jun 23, 2023

Fixes #1438

Description

Add your description here, if it fixes a particular issue please provide a link to the issue.

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

No schema changes

Fixes #1438.
When connection with node restarts, the db-sync threads are no
longer killed. Also when an exception is thrown in a DBSync thread,
it is no longer caught by the chainsync client
@kderme kderme requested a review from a team as a code owner June 23, 2023 13:29
@kderme kderme merged commit 1f39c5e into master Jun 27, 2023
@iohk-bors iohk-bors bot deleted the kderme/fix-concurrency branch June 27, 2023 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve concurrency and exception handling
1 participant