Update dependencied to Node-8.2.0-pre #1476
Conversation
| , DCertDeleg $ DeRegKey $ unregisteredStakeCredentials !! 2 | ||
| , DCertDeleg $ Delegate $ Delegation (unregisteredStakeCredentials !! 1) (unregisteredPools !! 2) | ||
| , DCertMir $ | ||
| [ ShelleyTxCertDelegCert $ ShelleyRegCert $ Prelude.head unregisteredStakeCredentials |
There was a problem hiding this comment.
Just checking I assume there will never be a scenario where the list is empty in the tests, since there is the use of head?
There was a problem hiding this comment.
Yes unregisteredStakeCredentials is hardcoded with 3 elements
| @@ -131,7 +133,7 @@ mkProtocolInfoCardano ge shelleyCred = | |||
| (Consensus.ProtocolTransitionParamsShelleyBased () $ dncMaryHardFork dnc) | |||
| (Consensus.ProtocolTransitionParamsShelleyBased alonzoGenesis $ dncAlonzoHardFork dnc) | |||
| (Consensus.ProtocolTransitionParamsShelleyBased () $ dncBabbageHardFork dnc) | |||
| (Consensus.ProtocolTransitionParamsShelleyBased (ConwayGenesis (GenDelegs mempty)) Consensus.TriggerHardForkNever) -- TODO: Conway Fix | |||
| (Consensus.ProtocolTransitionParamsShelleyBased (ConwayGenesis (GenDelegs mempty)) (Consensus.TriggerHardForkAtEpoch (EpochNo 34))) -- TODO: Conway Fix | |||
There was a problem hiding this comment.
maybe a little note as to why hard fork at epoch 34?
There was a problem hiding this comment.
Yes this needs to change. It's hardcoded 34 for sanchonet, but needs to be parsed from the config file before this is merged.
There was a problem hiding this comment.
Cool thanks, so it's usually an option in the config file
|
LGTM, except for the CI failures. I believe this is related to the updated dependencies and not the changes introduced here. |
This will allow us to update hackage without bringing in nixpkgs updates from haskell.nix
|
It looks like there were some hlint failures: https://ci.iog.io/build/567612/nixlog/89 |
Description
Allows db-sync to follow sanchonet.
Checklist
fourmoluon version 0.10.1.0 (which can be run withscripts/fourmolize.sh)Migrations
If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.