Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it build with ghc-9.6 #1479

Merged
merged 3 commits into from
Aug 11, 2023
Merged

Make it build with ghc-9.6 #1479

merged 3 commits into from
Aug 11, 2023

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Aug 10, 2023

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • Self-reviewed the diff

Migrations

No breaking change

angerman
angerman previously approved these changes Aug 10, 2023
Copy link
Contributor

@angerman angerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

kderme
kderme previously approved these changes Aug 10, 2023
@sgillespie
Copy link
Contributor

Looks good, but there will be a merge conflict. When can we make 9.2 or 9.6 the default?

@sgillespie
Copy link
Contributor

One other thing I just realized is we'll probably want to add a variant for ghc962 here: https://github.com/input-output-hk/cardano-db-sync/blob/master/nix/haskell.nix#L60

@erikd erikd merged commit 291bd0d into master Aug 11, 2023
8 of 30 checks passed
@iohk-bors iohk-bors bot deleted the erikd/ghc-9.6 branch August 11, 2023 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants