Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Conway Tests #1529

Merged
merged 7 commits into from
Nov 8, 2023
Merged

Conversation

sgillespie
Copy link
Contributor

@sgillespie sgillespie commented Oct 3, 2023

Description

Addresses a subset of #1526. In particular, I've added the following test groups:

  • Simple
  • Command Line Arguments

I've also snuck in a few minor improvements:

  • Omit postgres logs from nix test runner output
  • Eliminated some duplication between the era-specific transaction forging

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

If there is a breaking change, especially a big one, please add a justification here. Please elaborate
more what the migration achieves, what it cannot achieve or why a migration is not possible.

@sgillespie sgillespie force-pushed the feature/conway-tests branch 15 times, most recently from b20f5f3 to b9bf630 Compare October 18, 2023 19:22
@sgillespie sgillespie force-pushed the feature/conway-tests branch 4 times, most recently from 5c94247 to 92c26bc Compare October 20, 2023 18:54
@sgillespie sgillespie marked this pull request as ready for review October 20, 2023 19:36
@sgillespie sgillespie requested a review from a team as a code owner October 20, 2023 19:36
@kderme
Copy link
Contributor

kderme commented Nov 7, 2023

I haven't checked but MigrateConsumedPruneTxOut tests may not pass.

@sgillespie
Copy link
Contributor Author

I haven't checked but MigrateConsumedPruneTxOut tests may not pass.

You're right:

prune with full tx rollback:                                             FAIL (0.33s)
          test/Test/Cardano/Db/Mock/Validate.hs:126:
          Unexpected tx unspent count between tx-in & tx-out
          expected: 12
           but got: 14
          Use -p '/consumed-tx-out + prune-tx-out.prune with full tx rollback/' to rerun this test only.

@kderme
Copy link
Contributor

kderme commented Nov 7, 2023

These tests have been adjusted at #1539 and require integration

@kderme kderme merged commit aab164e into IntersectMBO:master Nov 8, 2023
8 of 10 checks passed
@sgillespie sgillespie deleted the feature/conway-tests branch November 8, 2023 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants