Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Committee keys size #1544

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix Committee keys size #1544

merged 1 commit into from
Oct 24, 2023

Conversation

kderme
Copy link
Contributor

@kderme kderme commented Oct 23, 2023

Description

Fixes #1543

Checklist

  • Commit sequence broadly makes sense
  • Commits have useful messages
  • New tests are added if needed and existing tests are updated
  • Any changes are noted in the changelog
  • Code is formatted with fourmolu on version 0.10.1.0 (which can be run with scripts/fourmolize.sh)
  • Self-reviewed the diff

Migrations

  • The pr causes a breaking change of type a,b or c
  • If there is a breaking change, the pr includes a database migration and/or a fix process for old values, so that upgrade is possible
  • Resyncing and running the migrations provided will result in the same database semantically

Changes schema with a migration

@ArturWieczorek
Copy link
Contributor

Should be working with fix on: sancho-2-1-0

./cardano-cli conway governance committee key-hash \
    --verification-key-file cc-cold.vkey > cc-key.hash

cat cc-key.hash
6a61d3862e74df10872a7426c107dad8cea9d784da4a150741e64141
sancho_2_1_0=# select * from committee_registration;
 id | tx_id | cert_index |                          cold_key                          |                          hot_key                           
----+-------+------------+------------------------------------------------------------+------------------------------------------------------------
  1 |  3547 |          0 | \xf17a38bc9c379cc4a251d28bc4ff1efefafd54d94dbd56a80772c14c | \x692e36ce9be15c669be3572f99b2239045006aae5baf9407d11522c9
  2 |  3562 |          0 | \x6a61d3862e74df10872a7426c107dad8cea9d784da4a150741e64141 | \xa600465da048f21ac753b26e4c136e7af51352d4ac77aa02c41c1c9f

No errors in the logs after waiting for a while:

[db-sync-node:Info:58] [2023-10-23 22:04:27.25 UTC] Insert Conway Block: continuing epoch 130 (slot 77667/86400)
[db-sync-node:Info:58] [2023-10-23 22:04:27.25 UTC] Insert Conway Block: epoch 130, slot 11309667, block 541940, hash 954ec67e5f4f8f79acfef35c9aa2fa5e0efe693ee7cbda7640e5c7733aad7e9a
[db-sync-node:Info:58] [2023-10-23 22:05:15.21 UTC] Insert Conway Block: epoch 130, slot 11309715, block 541941, hash 47bd108490cc82c524687de7291efd6c8b09ecc64d9de74362ed0732d78a1324
[db-sync-node:Info:58] [2023-10-23 22:05:57.16 UTC] Insert Conway Block: epoch 130, slot 11309757, block 541942, hash ca9eb559970da10b681f80f1f69d44d6b8c8c2b0b42cc3a603764be25822dcad
[db-sync-node:Info:58] [2023-10-23 22:07:01.28 UTC] Insert Conway Block: epoch 130, slot 11309821, block 541943, hash 3bcad100e458c1df42cf4b0bfdfd0187c8ede51c71dbceb00891f1b0542395a6
[db-sync-node:Info:58] [2023-10-23 22:07:16.24 UTC] Insert Conway Block: epoch 130, slot 11309836, block 541944, hash f78fdcdb4e0d0c56a8f5a457f927df78330c47e945ae4027f6f319412447bd8d
[db-sync-node:Info:58] [2023-10-23 22:07:19.10 UTC] Insert Conway Block: epoch 130, slot 11309839, block 541945, hash c792794f2e46bcd8fd6654a8b87271d0869b59a8c960aad6535eb1801c384135
[db-sync-node:Info:58] [2023-10-23 22:09:22.20 UTC] Insert Conway Block: epoch 130, slot 11309962, block 541946, hash 1aae1381734d5a62bc6b65b6d90c08920fe0e7beb2651d53e448385c3487549c
[db-sync-node:Info:58] [2023-10-23 22:10:19.17 UTC] Insert Conway Block: epoch 130, slot 11310019, block 541947, hash 41bbfdb7dbe337a05f2a59d618049076d8b4dc13f0cac60ea21ade8131ec8356
[db-sync-node:Info:58] [2023-10-23 22:10:50.29 UTC] Insert Conway Block: epoch 130, slot 11310050, block 541948, hash 133c5db399ef7b242d2b0b7fb8b817b2d41eb35c68fb90d3c651af02ac12bf2f
[db-sync-node:Info:58] [2023-10-23 22:11:06.27 UTC] Insert Conway Block: epoch 130, slot 11310066, block 541949, hash da4d983abc9924fd91a69dbe45ba8a9b9a70a58e8b2e536f3f9eeb98e17c8219
[db-sync-node:Info:58] [2023-10-23 22:11:36.15 UTC] Insert Conway Block: epoch 130, slot 11310096, block 541950, hash 9287363ed906800714a86295398099559e14c6d034285f8819d5a4e8761aab1c
[db-sync-node:Info:58] [2023-10-23 22:11:55.16 UTC] Insert Conway Block: epoch 130, slot 11310115, block 541951, hash 13eb7ed3d82474cb9414ff0836ab56a8dcd6d3ecbf795b02e2783f952cc9ff45
[db-sync-node:Info:58] [2023-10-23 22:12:13.10 UTC] Insert Conway Block: epoch 130, slot 11310133, block 541952, hash 6ee3d8a55e28afedbc9bfd11799cb139e0252e43eaebfb6c94824c075a4ede9a
[db-sync-node:Info:58] [2023-10-23 22:13:04.15 UTC] Insert Conway Block: epoch 130, slot 11310184, block 541953, hash 12001b4333efcb963af1231f253ab1366e56bd101f0c3a9f52a9c3fa8ecbe4d2

@kderme kderme merged commit 083d302 into master Oct 24, 2023
30 of 32 checks passed
@iohk-bors iohk-bors bot deleted the sancho-2-1-0 branch October 24, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DbInsertException "CommitteeRegistration": value for domain addr29type violates check constraint
2 participants