Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] - cardano-cli should validate relays information when a new SPO registers #4929

Open
coot opened this issue Mar 2, 2023 · 3 comments
Open
Labels
CLI comp: cardano-cli type: enhancement An improvement on the existing functionality

Comments

@coot
Copy link
Contributor

coot commented Mar 2, 2023

Internal & External

Area
cardano-cli registration

Describe the feature you'd like
cardano-cli should be more strict when accepting registration certificates. A list of common mistakes:

  • registering with IP address as a domain name
  • using private IP addresses
  • not providing port or providing invalid port
  • invalid DNS names
  • register with IOG relays

We could also use cardano-ping to check that we can connect to relays. This will not capture miss configurations when the relays are running behind a NAT though, for that we'd need to design an external service.

@coot coot added the type: enhancement An improvement on the existing functionality label Mar 2, 2023
@karknu
Copy link
Contributor

karknu commented Mar 2, 2023

@coot
Copy link
Contributor Author

coot commented Mar 2, 2023

@JaredCorduan some rules could be ledger rules (applied after a future HF):

  • port is not null
  • http / https is not part of domain name

@github-actions
Copy link

github-actions bot commented Apr 2, 2023

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 120 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLI comp: cardano-cli type: enhancement An improvement on the existing functionality
Projects
Status: No status
Development

No branches or pull requests

3 participants