Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cardano-api] Export fromConsensusPointHF #4684

Merged
merged 1 commit into from
May 9, 2023
Merged

[cardano-api] Export fromConsensusPointHF #4684

merged 1 commit into from
May 9, 2023

Conversation

ch1bo
Copy link
Contributor

@ch1bo ch1bo commented Nov 30, 2022

As toConsensusPointHF is also exported

@ch1bo ch1bo force-pushed the ch1bo/cardano-api-export-fromConsensusPointHF branch from 0222cb4 to 40c5490 Compare November 30, 2022 08:51
@ch1bo
Copy link
Contributor Author

ch1bo commented Nov 30, 2022

Not sure if this is intended to be used in the first place? Or do we want to guide users to use fromConsensusPointInMode? The implementation of that one seems to be always fromConsensusPointHF though.

@newhoggy newhoggy force-pushed the ch1bo/cardano-api-export-fromConsensusPointHF branch from 40c5490 to f0f4504 Compare March 1, 2023 02:07
@newhoggy newhoggy force-pushed the ch1bo/cardano-api-export-fromConsensusPointHF branch from f0f4504 to f952850 Compare May 6, 2023 07:08
@newhoggy newhoggy enabled auto-merge May 6, 2023 07:08
@newhoggy newhoggy added this pull request to the merge queue May 6, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 6, 2023
@ch1bo @newhoggy
Export fromConsensusPointHF
2556983 
As toConsensusPointHF is also exported
@newhoggy newhoggy force-pushed the ch1bo/cardano-api-export-fromConsensusPointHF branch from f952850 to 2556983 Compare May 6, 2023 11:21
@newhoggy newhoggy enabled auto-merge May 6, 2023 11:21
@newhoggy newhoggy added this pull request to the merge queue May 9, 2023
Merged via the queue into master with commit a245e2b May 9, 2023
@iohk-bors iohk-bors bot deleted the ch1bo/cardano-api-export-fromConsensusPointHF branch May 9, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jimbo4350 Jimbo4350 Jimbo4350 approved these changes

@dcoutts dcoutts Awaiting requested review from dcoutts

@erikd erikd Awaiting requested review from erikd

@newhoggy newhoggy Awaiting requested review from newhoggy

@JaredCorduan JaredCorduan Awaiting requested review from JaredCorduan

@LudvikGalois LudvikGalois Awaiting requested review from LudvikGalois

@CarlosLopezDeLara CarlosLopezDeLara Awaiting requested review from CarlosLopezDeLara

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ch1bo @Jimbo4350 @newhoggy