Better error message for query utxo without oops 2 #4825
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
commented
Jan 21, 2023
| pure (utxo, pparams, eraHistory, systemStart, stakePools) | ||
| ) & onLeft (throwE . AcqFailure) | ||
| & onLeft (throwE . ConvenienceUnsupportedNtcVersionError) | ||
| & onLeft (throwE . QueryEraMismatch) |
There was a problem hiding this comment.
Some queries like QueryUTxO, QueryProtocolParameters and QueryStakePools return their own errors (in this case EraMismatch) so needs to be handled with an extra ExceptT stack.
Unfortunately this means that if a query is added to an expression that requires an extra layer in the stack, all queries in the query expression will need to be changed to accomodate that extra layer.
This is a problem that does not exist when using oops: https://github.com/input-output-hk/cardano-node/pull/4777/files#r1084878188
newhoggy
requested review from
dcoutts,
Jimbo4350,
erikd,
JaredCorduan and
CarlosLopezDeLara
as code owners
newhoggy
force-pushed
the
newhoggy/better-error-message-for-query-utxo-without-oops-2
branch
from
0731f2c to
f980e2c
Compare
Jimbo4350
previously requested changes
Jan 24, 2023
| systemStart <- ExceptT $ fmap Right $ ExceptT $ queryExpr systemStartQuery | ||
| stakePools <- ExceptT $ ExceptT $ queryExpr stakePoolsQuery | ||
| pure (utxo, pparams, eraHistory, systemStart, stakePools) | ||
| ) & onLeft (throwE . AcqFailure) |
newhoggy
force-pushed
the
newhoggy/better-error-message-for-query-utxo-without-oops-2
branch
from
f980e2c to
d42248c
Compare
newhoggy
force-pushed
the
newhoggy/better-error-message-for-query-utxo-without-oops-2
branch
2 times, most recently
from
9991222 to
0f58e07
Compare
newhoggy
force-pushed
the
newhoggy/better-error-message-for-query-utxo-without-oops-2
branch
4 times, most recently
from
acfa660 to
9a6bbf3
Compare
Jimbo4350
reviewed
Feb 13, 2023
| stakePools <- ExceptT $ executeQueryCardanoMode era networkId stakePoolsQuery | ||
|
|
||
| return (utxo, pparams, eraHistory, systemStart, stakePools) | ||
| ( lift $ executeLocalStateQueryExpr localNodeConnInfo Nothing $ runExceptT $ runExceptT $ do |
There was a problem hiding this comment.
Can we hold off until oops is integrated? This is a decrease in readability imo.
There was a problem hiding this comment.
I still think this is a decrease in readability. I'll start a discussion on slack today.
newhoggy
force-pushed
the
newhoggy/better-error-message-for-query-utxo-without-oops-2
branch
2 times, most recently
from
a86c929 to
5bb8cf0
Compare
newhoggy
requested review from
a team,
coot,
deepfire,
jutaro,
mgmeier and
fmaste
as code owners
newhoggy
force-pushed
the
newhoggy/better-error-message-for-query-utxo-without-oops-2
branch
from
5bb8cf0 to
3205ae9
Compare
newhoggy
force-pushed
the
newhoggy/better-error-message-for-query-utxo-without-oops-2
branch
from
3205ae9 to
ad13aa2
Compare
Jimbo4350
requested changes
Mar 29, 2023
| stakePools <- ExceptT $ executeQueryCardanoMode era networkId stakePoolsQuery | ||
|
|
||
| return (utxo, pparams, eraHistory, systemStart, stakePools) | ||
| ( lift $ executeLocalStateQueryExpr localNodeConnInfo Nothing $ runExceptT $ runExceptT $ do |
There was a problem hiding this comment.
I still think this is a decrease in readability. I'll start a discussion on slack today.
newhoggy
commented
Mar 31, 2023
| pparams <- ExceptT $ ExceptT $ queryExpr pparamsQuery | ||
| eraHistory <- ExceptT $ fmap Right $ ExceptT $ queryExpr eraHistoryQuery | ||
| systemStart <- ExceptT $ fmap Right $ ExceptT $ queryExpr systemStartQuery | ||
| stakePools <- ExceptT $ ExceptT $ queryExpr stakePoolsQuery |
newhoggy
force-pushed
the
newhoggy/better-error-message-for-query-utxo-without-oops-2
branch
from
ad13aa2 to
f97d75b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this is merged, we no longer need
executeQueryCardanoModeas it is no longer used anywhere.A subsequent PR will delete this function.