Use cardano-api from separate repository #5047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
force-pushed
the
newhoggy/use-cardano-api-from-separate-repository
branch
8 times, most recently
from
bd0451d to
d3edfb8
Compare
Jimbo4350
requested review from
Jimbo4350,
a team,
dcoutts,
erikd,
JaredCorduan and
CarlosLopezDeLara
as code owners
Jimbo4350
approved these changes
May 12, 2023
newhoggy
force-pushed
the
newhoggy/use-cardano-api-from-separate-repository
branch
from
d3edfb8 to
868fb0e
Compare
newhoggy
requested review from
deepfire,
jutaro,
mgmeier,
fmaste and
cleverca22
as code owners
newhoggy
force-pushed
the
newhoggy/use-cardano-api-from-separate-repository
branch
7 times, most recently
from
f1fec3d to
f5dfaae
Compare
newhoggy
force-pushed
the
newhoggy/use-cardano-api-from-separate-repository
branch
from
f5dfaae to
ab14e54
Compare
newhoggy
force-pushed
the
newhoggy/use-cardano-api-from-separate-repository
branch
from
ab14e54 to
15ff803
Compare
carbolymer
reviewed
May 15, 2023
| @@ -230,7 +230,7 @@ test-suite cardano-cli-golden | |||
| build-depends: aeson >= 1.5.6.0 | |||
| , base16-bytestring | |||
| , bytestring | |||
| , cardano-api | |||
| , cardano-api ^>= 8.1.0.1 | |||
There was a problem hiding this comment.
cardano-cli-test , cardano-cli-golden, depend on cardano-cli. The version bounds in cardano-cli should be enough to correctly resolve dependency version and the version bounds here seem redundant.
carbolymer
previously requested changes
May 15, 2023
|
@carbolymer has created a draft ADR regarding constraints. input-output-hk/cardano-node-wiki#7 I think it's okay to merge this PR without resolving the questions in the ADR and come back to implement the ADR in a separate PR. |
erikd
approved these changes
May 15, 2023
carbolymer
approved these changes
May 16, 2023
mgmeier
approved these changes
May 16, 2023
JaredCorduan
approved these changes
May 17, 2023
olgahryniuk
approved these changes
May 17, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to Branch Protection failures
You're not authorized to push to this branch. Visit "About protected branches" for more information.
iohk-bors
bot
deleted the
newhoggy/use-cardano-api-from-separate-repository
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.