Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose LocalTxSubmissionClient data constructor #5096

Merged
merged 1 commit into from
May 6, 2023

Conversation

ch1bo
Copy link
Contributor

@ch1bo ch1bo commented Apr 14, 2023

Any user of the LocalNodeClientProtocols IPC interface will need to construct this type. Hence it needs to be exported.

@newhoggy
Copy link
Contributor

src/Cardano/Api.hs:660:5: error: [-Wduplicate-exports, -Werror=duplicate-exports]
    ‘runLocalTxSubmissionClient’ is exported by ‘runLocalTxSubmissionClient’ and ‘LocalTxSubmissionClient(..)’
    |
660 |     runLocalTxSubmissionClient,
    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^

@newhoggy
Copy link
Contributor

Also can you tell me more about your use case that you should need to use LocalTxSubmissionClient directly?

@ch1bo
Copy link
Contributor Author

ch1bo commented Apr 14, 2023

Also can you tell me more about your use case that you should need to use LocalTxSubmissionClient directly?

Of course. In https://github.com/input-output-hk/hydra we are connecting to a local cardano-node to submit transactions using the ouroboros node-to-client protocol. Lately I tried to use the IPCmodule from cardano-api, instead of ouroboros-network-framework and protocols directly.

@newhoggy newhoggy force-pushed the ch1bo/expose-local-tx-submission-client branch from aab4143 to e1bb303 Compare April 26, 2023 06:38
@newhoggy
Copy link
Contributor

I pushed a commit to fix the compile error.

@newhoggy newhoggy force-pushed the ch1bo/expose-local-tx-submission-client branch from e1bb303 to 78df49f Compare April 26, 2023 06:48
Any user of the LocalNodeClientProtocols IPC interface will need to
construct this type. Hence it needs to be exported.
@newhoggy newhoggy force-pushed the ch1bo/expose-local-tx-submission-client branch from 78df49f to dc73538 Compare May 6, 2023 06:55
@newhoggy newhoggy enabled auto-merge May 6, 2023 06:56
@newhoggy newhoggy added this pull request to the merge queue May 6, 2023
Merged via the queue into master with commit fc6130e May 6, 2023
@iohk-bors iohk-bors bot deleted the ch1bo/expose-local-tx-submission-client branch May 6, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants